Re: review: Simple patch to remove the dmapi support from xfsdump

Dean Roehrich
2006-08-07T15:04:23Z

On Fri, Aug 04, 2006 at 04:59:45PM -0500, Bill Kendall wrote:

> -#define DMF_EV_BITS ( (1<<DM_EVENT_DESTROY) | \
> - (1<<DM_EVENT_READ) | \
> - (1<<DM_EVENT_WRITE) | \
> - (1<<DM_EVENT_TRUNCATE) )
> +#define DMF_EV_BITS ( (1<<16) | (1<<17) | (1<<18) | (1<<20) )

Don't do that.

Granted, those bits can never be changed else all of your customers will start
a lynch mob and come after you.

At the very least, don't allow those bits to be anonymous--copy that whole
enum from the dmapi header. Even that I object to, but at least the bits will
_be_ something.

Dean