From: Zach Brown <zach.brown@oracle.com>
To: xfs@oss.sgi.com
Subject: xfs_end_io_direct() with negative size?
Date: Fri, 11 Aug 2006 10:43:12 -0700 [thread overview]
Message-ID: <44DCC1B0.70003@oracle.com> (raw)
So, I was lost in fs/direct-io.c chasing yet another bug when I noticed
that a recent unrelated change might have changed the semantics of the
end_io() call.
http://www.kernel.org/hg/linux-2.6/?cs=34c151cf341f
Notice how that changes the aio path to set 'transferred' to -EIO based
on dio->io_error before calling dio_complete() instead of after, like
the sync path does with its possibly negative 'ret'.
So it looks like xfs_end_io_direct() can now get a -ve size if, say,
someone unplugs a drive part-way through a dio+aio write. There's an
ASSERT() in there that makes me wonder if this is something we should be
worrying about.
- z
next reply other threads:[~2006-08-11 19:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-11 17:43 Zach Brown [this message]
2006-08-14 0:22 ` xfs_end_io_direct() with negative size? Nathan Scott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44DCC1B0.70003@oracle.com \
--to=zach.brown@oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox