From: Eric Sandeen <sandeen@sandeen.net>
To: Nathan Scott <nathans@sgi.com>
Cc: Jesper Juhl <jesper.juhl@gmail.com>, xfs@oss.sgi.com
Subject: Re: review: cleanup xfs_da_node_lookup_int (was Re: [PATCH] XFS: possibly uninitialized variable use in fs/xfs/xfs_da_btree.c::xfs_da_node_lookup_int())
Date: Mon, 14 Aug 2006 11:00:06 -0500 [thread overview]
Message-ID: <44E09E06.9020400@sandeen.net> (raw)
In-Reply-To: <20060814155609.G2698880@wobbly.melbourne.sgi.com>
Nathan Scott wrote:
> On Sat, Aug 12, 2006 at 10:24:54PM -0500, Eric Sandeen wrote:
>> ...
>> FWIW seems like there's a lot of unnecessary endian flipping in there too; I
>> haven't tested this but since it endian-flips the magic into blk->magic seems
>> like it may as well use it:
>
> How's this look?
Looks good to me.
(now that I look closer & grok that there are 2 loops in that function
and the break is in the nested one... oops!)
-Eric
next prev parent reply other threads:[~2006-08-14 16:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-12 21:34 [PATCH] XFS: possibly uninitialized variable use in fs/xfs/xfs_da_btree.c::xfs_da_node_lookup_int() Jesper Juhl
2006-08-13 3:24 ` Eric Sandeen
2006-08-14 5:56 ` review: cleanup xfs_da_node_lookup_int (was Re: [PATCH] XFS: possibly uninitialized variable use in fs/xfs/xfs_da_btree.c::xfs_da_node_lookup_int()) Nathan Scott
2006-08-14 16:00 ` Eric Sandeen [this message]
2006-08-16 21:05 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44E09E06.9020400@sandeen.net \
--to=sandeen@sandeen.net \
--cc=jesper.juhl@gmail.com \
--cc=nathans@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox