Re: review: cleanup xfs_da_node_lookup_int (was Re: [PATCH] XFS: possibly uninitialized variable use in fs/xfs/xfs_da_btree.c::xfs_da_node_lookup_int())

Jesper Juhl
2006-08-16T21:06:53Z

On 14/08/06, Nathan Scott <nathans@sgi.com> wrote:
> On Sat, Aug 12, 2006 at 10:24:54PM -0500, Eric Sandeen wrote:
> > ...
> > FWIW seems like there's a lot of unnecessary endian flipping in there too; I
> > haven't tested this but since it endian-flips the magic into blk->magic seems
> > like it may as well use it:
>
> How's this look?
>
As far as I can see it looks good, but I'm still just starting to read
the XFS code, so I'm far from reliable yet ;-)

--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html