Re: review: cleanup xfs_da_node_lookup_int (was Re: [PATCH] XFS: possibly uninitialized variable use in fs/xfs/xfs_da_btree.c::xfs_da_node_lookup_int())

Eric Sandeen
2006-08-14T16:59:44Z

Nathan Scott wrote:
> On Sat, Aug 12, 2006 at 10:24:54PM -0500, Eric Sandeen wrote:
>> ...
>> FWIW seems like there's a lot of unnecessary endian flipping in there too; I
>> haven't tested this but since it endian-flips the magic into blk->magic seems
>> like it may as well use it:
>
> How's this look?

Looks good to me.

(now that I look closer & grok that there are 2 loops in that function
and the break is in the nested one... oops!)

-Eric