From: Vlad Apostolov <vapo@sgi.com>
To: Nathan Scott <nathans@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: review: greedy allocator vs kmflags
Date: Mon, 28 Aug 2006 17:00:28 +1000 [thread overview]
Message-ID: <44F2948C.4070005@sgi.com> (raw)
In-Reply-To: <20060828163004.B3100886@wobbly.melbourne.sgi.com>
Nathan Scott wrote:
> Hi Vlad,
>
> This is the last iteration on updating the greedy alloc routine to
> be more generic and properly handle the passed in flags wrt sleep or
> nosleep (following up on Dave's suggestion, and someone else to me
> privately, offlist). Could you give it a final review for me?
>
> thanks.
>
>
It is looking good Nathan. One thing I noticed today when I was building
the modules
was that kmem_zalloc_greedy() is already in use in several places. There
were a few warnings about type mismatch of the first argument "size_t
*size" and
missing kmem_zalloc_greedy symbol at the end. Not sure if this is
important but just
thought to mention it.
Regards,
Vlad
parent reply other threads:[~2006-08-28 7:00 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20060828163004.B3100886@wobbly.melbourne.sgi.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44F2948C.4070005@sgi.com \
--to=vapo@sgi.com \
--cc=nathans@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox