public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Lachlan McIlroy <lachlan@sgi.com>
To: Nathan Scott <nathans@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: review: minor cleanup in xfs_read locking
Date: Mon, 04 Sep 2006 01:31:54 +0100	[thread overview]
Message-ID: <44FB73FA.6010400@sgi.com> (raw)
In-Reply-To: <20060904101711.A3331169@wobbly.melbourne.sgi.com>

Looks good Nathan.

I've made changes to check return codes from bhv_vop_flushinval_pages()
and friends so it's now dependent on this change.  I'll post a review
as soon as your change has gone in.

Nathan Scott wrote:
> Hi Lachlan,
> 
> Could you check this for me - it just folds the second direct I/O
> conditional added in your recent deadlock fix back into the prior
> branch, which is also direct I/O specific...
> 
> thanks.
> 

  reply	other threads:[~2006-09-04  1:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-04  0:17 review: minor cleanup in xfs_read locking Nathan Scott
2006-09-04  0:31 ` Lachlan McIlroy [this message]
2006-09-04  0:39 ` Lachlan McIlroy
2006-09-04  1:09   ` Nathan Scott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44FB73FA.6010400@sgi.com \
    --to=lachlan@sgi.com \
    --cc=nathans@sgi.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox