From: Lachlan McIlroy <lachlan@sgi.com>
To: Nathan Scott <nathans@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: review: minor cleanup in xfs_read locking
Date: Mon, 04 Sep 2006 01:39:39 +0100 [thread overview]
Message-ID: <44FB75CB.8050809@sgi.com> (raw)
In-Reply-To: <20060904101711.A3331169@wobbly.melbourne.sgi.com>
Looking a little closer... you could probably do away with the extra
pair of parentheses in the call to unlikely().
Nathan Scott wrote:
> Hi Lachlan,
>
> Could you check this for me - it just folds the second direct I/O
> conditional added in your recent deadlock fix back into the prior
> branch, which is also direct I/O specific...
>
> thanks.
>
next prev parent reply other threads:[~2006-09-04 1:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-04 0:17 review: minor cleanup in xfs_read locking Nathan Scott
2006-09-04 0:31 ` Lachlan McIlroy
2006-09-04 0:39 ` Lachlan McIlroy [this message]
2006-09-04 1:09 ` Nathan Scott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44FB75CB.8050809@sgi.com \
--to=lachlan@sgi.com \
--cc=nathans@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox