Re: [PATCH -mm] rescue large xfs preferred iosize from the inode diet patch

David Chinner
2006-09-22T06:20:51Z

On Thu, Sep 21, 2006 at 09:43:17PM -0500, Eric Sandeen wrote:
> Eric Sandeen wrote:
> >
> >Ah, ok, thanks guys. Should have checked CVS I guess.
> >
> cc -= lkml;
>
> actually the patch nathan put in seems like a lot of replicated code.

Yeah, that's what caught me - I looked at the tree which had nathan's
patch in it, and assumed that the stuff the -mm tree had cleaned it up
to use the generic_fillattr() code.

> But maybe he's solving some problem I didn't think of.

The difference is the old code updated the fields in the linux inode
with all the info from disk and then filled in the stat data from
the linux inode. The new code gets the data from "disk" and puts it
straight into the the stat buffer without updating the linux inode.

> Any idea what?

I would have thought that we want what we report to userspace to be
consistent in the linux inode as well. I suppose that by duplicating
the code we removed a copy of the data but I see little advantage
from doing that considering the extra code to do it and the fat that
the linux inode may not be up to date now....

Cheers,

Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group