Re: Data type overflow in xfs_trans_unreserve_and_mod_sb

Shailendra Tripathi
2006-09-25T14:56:46Z

Eric Sandeen wrote:
> Hm, yep, just ASSERT(error == 0);
>
> I suppose this is the trickiness of canceling a transaction at some
> points...

Yes, you are right. At the point where it is being applied, all the
things can't be reverted back as XFS does not store the "before-image".
However, typically in most of such cases, XFS goes ahead with shutting
down the filesystem assuming these to be catastrophic or incorrigible
errors requiring manual intervention.

> First thoughts, "long" won't help on 32 bit machines, perhaps this
> should be an explicitly-sized 64-bit type

> -Eric
>
> p.s. good to see agami's recently active participation on the list!
>