Re: Data type overflow in xfs_trans_unreserve_and_mod_sb

Shailendra Tripathi
2006-10-13T08:35:15Z

David Chinner wrote:
>>Eric, you suggested specific 64 bit types - I think that's really the
>>way to fix this, but it's a much bigger change...
>
>
> Shailendra, here's a patch that passes XFSQA that changes this all to 64 bit
> types. I've had to fix various type abuses that weren't obvious because gcc
> fails to warn when you pass a uint into a function parameter that is declared
> as int64_t.....
>
> I haven't tested the >2TB grow case yet, but it should work now
> on both 32bit and 64 bit platforms with this patch.
>
> Is there anything I missed here in the conversion?
>
> Cheers,
>
> Dave.

Looks ok to me, Dave.
Thanks.