From: Shailendra Tripathi <stripathi@agami.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: David Chinner <dgc@sgi.com>,
xfs@oss.sgi.com, Timothy Shimmin <tes@sgi.com>
Subject: Re: Data type overflow in xfs_trans_unreserve_and_mod_sb
Date: Mon, 25 Sep 2006 20:22:49 +0530 [thread overview]
Message-ID: <4517ED41.8090305@agami.com> (raw)
In-Reply-To: <4517E88E.4020809@sandeen.net>
Eric Sandeen wrote:
> Hm, yep, just ASSERT(error == 0);
>
> I suppose this is the trickiness of canceling a transaction at some
> points...
Yes, you are right. At the point where it is being applied, all the
things can't be reverted back as XFS does not store the "before-image".
However, typically in most of such cases, XFS goes ahead with shutting
down the filesystem assuming these to be catastrophic or incorrigible
errors requiring manual intervention.
> First thoughts, "long" won't help on 32 bit machines, perhaps this
> should be an explicitly-sized 64-bit type
> -Eric
>
> p.s. good to see agami's recently active participation on the list!
>
next prev parent reply other threads:[~2006-09-25 14:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-23 13:27 largeio mount and performance impact Sebastian Brings
2006-09-23 16:34 ` Eric Sandeen
2006-09-24 13:41 ` Sebastian Brings
2006-09-24 13:47 ` Sebastian Brings
2006-09-25 8:38 ` Data type overflow in xfs_trans_unreserve_and_mod_sb Shailendra Tripathi
2006-09-25 14:32 ` Eric Sandeen
2006-09-25 14:52 ` Shailendra Tripathi [this message]
2006-10-11 5:25 ` David Chinner
2006-10-13 6:13 ` David Chinner
2006-10-13 8:31 ` Shailendra Tripathi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4517ED41.8090305@agami.com \
--to=stripathi@agami.com \
--cc=dgc@sgi.com \
--cc=sandeen@sandeen.net \
--cc=tes@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox