public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: sandeen@sandeen.net
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/2] Remove unused stuff
Date: Fri, 29 Sep 2006 12:06:02 -0500	[thread overview]
Message-ID: <451D527A.6080904@sandeen.net> (raw)
In-Reply-To: <20060929032916.AB75B18001A5F@sandeen.net>

sandeen@sandeen.net wrote:
> And now that things are static, remove things that are not used.
> 
>  xfs_bmap.c       |   36 ------------------
>  xfs_bmap_btree.c |   74 -------------------------------------
>  xfs_bmap_btree.h |   11 -----
>  xfs_da_btree.c   |   15 -------
>  xfs_da_btree.h   |    1 
>  xfs_error.c      |   26 -------------
>  xfs_error.h      |    1 
>  xfs_rtalloc.c    |  108 -------------------------------------------------------
>  xfs_rtalloc.h    |   18 ---------
>  9 files changed, 290 deletions(-)
> 
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>


I suppose that if this code is deemed useful, maybe it could be moved to
some xfs_*_debug.[ch] files so it's not lost....

Hm, or looks like some of it is used in userspace (xfs_da_log2_roundup)
it could be moved there if not ever used in the kernel.  (although from
a quick look I'm not sure that's doing anything useful there either,
anymore).

-Eric

      reply	other threads:[~2006-09-29 17:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-29  3:29 [PATCH 2/2] Remove unused stuff sandeen
2006-09-29 17:06 ` Eric Sandeen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=451D527A.6080904@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox