From: Eric Sandeen <sandeen@sandeen.net>
To: David Chinner <dgc@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: xfs vs. lockdep
Date: Mon, 09 Oct 2006 21:25:43 -0500 [thread overview]
Message-ID: <452B04A7.3090400@sandeen.net> (raw)
In-Reply-To: <20061010004726.GO11034@melbourne.sgi.com>
David Chinner wrote:
> FWIW, we call mrfree() on both the ilock and the iolock, but these are
> #defined to null statements. If there is a destructor for the underlying
> lock type, we probably should call that in mrfree() so the debugging code
> can catch these probelms that only trigger in debug code.
From a quick look I don't see those destructors, might be good to write some
though.
It'd also be good to turn our spinlock_destroy(lock) into a
WARN_ON(spin_is_locked(lock)) or something...
it'd be extra nice if lockdep could grok that the lock it's looking at is full
of free poison, print a warning, take it off the list and move on... this was a
bear to figure out which one was causing the problem.
I have a few changes to get more desructors called for some of the newer locks
that are missing them (think agirotor_lock...) that I'll send when I get a moment.
-Eric
> Cheers,
>
> Dave.
prev parent reply other threads:[~2006-10-10 2:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-09 17:58 xfs vs. lockdep Eric Sandeen
2006-10-09 23:36 ` Vlad Apostolov
2006-10-10 3:06 ` Eric Sandeen
2006-10-10 3:23 ` Vlad Apostolov
2006-10-10 0:47 ` David Chinner
2006-10-10 1:45 ` Timothy Shimmin
2006-10-10 2:21 ` Eric Sandeen
2006-10-10 4:55 ` Timothy Shimmin
2006-10-10 2:25 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=452B04A7.3090400@sandeen.net \
--to=sandeen@sandeen.net \
--cc=dgc@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox