From: Shailendra Tripathi <stripathi@agami.com>
To: David Chinner <dgc@sgi.com>
Cc: sandeen@sandeen.net, xfs@oss.sgi.com, Timothy Shimmin <tes@sgi.com>
Subject: Re: Data type overflow in xfs_trans_unreserve_and_mod_sb
Date: Fri, 13 Oct 2006 14:01:27 +0530 [thread overview]
Message-ID: <452F4EDF.6010500@agami.com> (raw)
In-Reply-To: <20061013061354.GF19345@melbourne.sgi.com>
David Chinner wrote:
>>Eric, you suggested specific 64 bit types - I think that's really the
>>way to fix this, but it's a much bigger change...
>
>
> Shailendra, here's a patch that passes XFSQA that changes this all to 64 bit
> types. I've had to fix various type abuses that weren't obvious because gcc
> fails to warn when you pass a uint into a function parameter that is declared
> as int64_t.....
>
> I haven't tested the >2TB grow case yet, but it should work now
> on both 32bit and 64 bit platforms with this patch.
>
> Is there anything I missed here in the conversion?
>
> Cheers,
>
> Dave.
Looks ok to me, Dave.
Thanks.
prev parent reply other threads:[~2006-10-13 8:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-23 13:27 largeio mount and performance impact Sebastian Brings
2006-09-23 16:34 ` Eric Sandeen
2006-09-24 13:41 ` Sebastian Brings
2006-09-24 13:47 ` Sebastian Brings
2006-09-25 8:38 ` Data type overflow in xfs_trans_unreserve_and_mod_sb Shailendra Tripathi
2006-09-25 14:32 ` Eric Sandeen
2006-09-25 14:52 ` Shailendra Tripathi
2006-10-11 5:25 ` David Chinner
2006-10-13 6:13 ` David Chinner
2006-10-13 8:31 ` Shailendra Tripathi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=452F4EDF.6010500@agami.com \
--to=stripathi@agami.com \
--cc=dgc@sgi.com \
--cc=sandeen@sandeen.net \
--cc=tes@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox