Re: [PATCH 1/2] Make stuff static

[Eric Sandeen <sandeen@sandeen.net>]

Timothy Shimmin wrote:
> Okay, started looking :-)
> 
> Some comments below...
> 
> --Tim

Thanks Tim! :)

>> --- xfs-linux.orig/linux-2.4/xfs_vnode.c
>> +++ xfs-linux/linux-2.4/xfs_vnode.c
>> @@ -17,7 +17,7 @@
>>  #include "xfs.h"
>>
>>  uint64_t vn_generation;        /* vnode generation number */
>> -spinlock_t vnumber_lock = SPIN_LOCK_UNLOCKED;
>> +static spinlock_t vnumber_lock = SPIN_LOCK_UNLOCKED;
>>
> 
> Not STATIC? Curious.

Yeah, probably should be; IIRC there were other "statics" in that file, was just 
following the convention.  I'll make sure it builds OK w/ STATIC and send an 
updated patch (need to do that anyway).

> Yep for all xfs_iext_ funcs.
> 
> Well actually it looks like xfs_bmap.c uses these:
> --------------------
> xfs_iext_add
> xfs_iext_bno_to_ext
> xfs_iext_get_ext
> xfs_iext_insert
> xfs_iext_remove
> ---------------------
> 
> So I'm not sure why some are still here...
> xfs_iext_destroy

Exported... maybe you can tell me why? :)

> xfs_iext_idx_to_irec

Same deal.

> xfs_iext_realloc  (only exists in header???)

Odd, missed that one, guess it can go too?  Maybe others lurk as well.

Thanks!

-Eric

> --Tim
> 
> 
>