From: Lachlan McIlroy <lachlan@sgi.com>
To: Utako Kusaka <utako@tnes.nec.co.jp>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs_bmap -n fix
Date: Fri, 20 Oct 2006 11:35:27 +0100 [thread overview]
Message-ID: <4538A66F.8060300@sgi.com> (raw)
In-Reply-To: <200610200418.AA04613@TNESG9305.tnes.nec.co.jp>
Hi Utako,
That's definitely a bug, thanks for the fix.
Lachlan
Utako Kusaka wrote:
> Hi,
>
> This patch fixes the issue that
> "xfs_bmap -n [nnn]" doesn't work correctly.
>
> Example:
> # xfs_io -c "bmap -n 3" test/file2
> test/file2:
> 0: [0..4849151]: 41943136..46792287
> 1: [4849152..51641343]: 46792768..93584959
> 2: [51641344..68418047]: 93585472..110362175
> # xfs_bmap -n 3 test/file2
> test/file2:
> 0: [0..4849151]: 41943136..46792287
> 1: [4849152..51641343]: 46792768..93584959
> 2: [51641344..98433535]: 93585472..140377663
> 3: [98433536..131987455]: 140378176..173932095
> 4: [131987456..145225727]: 173932104..187170375
> 5: [145225728..192017919]: 187170880..233963071
> 6: [192017920..209715199]: 233963584..251660863
>
> Signed-off-by: Utako Kusaka <utako@tnes.nec.co.jp>
> ---
>
> --- xfsprogs-2.8.11-orgn/io/xfs_bmap.sh 2006-06-26 14:01:15.000000000 +0900
> +++ xfsprogs-2.8.11/io/xfs_bmap.sh 2006-10-20 12:22:19.771009697 +0900
> @@ -14,7 +14,7 @@ do
> a) OPTS=$OPTS" -a";;
> d) OPTS=$OPTS" -d";;
> l) OPTS=$OPTS" -l";;
> - n) OPTS=$OPTS" '-n "$OPTARG"'";;
> + n) OPTS=$OPTS" -n "$OPTARG"";;
> p) OPTS=$OPTS" -p";;
> v) OPTS=$OPTS" -v";;
> V) VERSION=true;;
>
>
prev parent reply other threads:[~2006-10-20 10:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-20 4:18 [PATCH] xfs_bmap -n fix Utako Kusaka
2006-10-20 10:35 ` Lachlan McIlroy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4538A66F.8060300@sgi.com \
--to=lachlan@sgi.com \
--cc=utako@tnes.nec.co.jp \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox