* [PATCH] xfs_bmap -n fix
@ 2006-10-20 4:18 Utako Kusaka
2006-10-20 10:35 ` Lachlan McIlroy
0 siblings, 1 reply; 2+ messages in thread
From: Utako Kusaka @ 2006-10-20 4:18 UTC (permalink / raw)
To: xfs
Hi,
This patch fixes the issue that
"xfs_bmap -n [nnn]" doesn't work correctly.
Example:
# xfs_io -c "bmap -n 3" test/file2
test/file2:
0: [0..4849151]: 41943136..46792287
1: [4849152..51641343]: 46792768..93584959
2: [51641344..68418047]: 93585472..110362175
# xfs_bmap -n 3 test/file2
test/file2:
0: [0..4849151]: 41943136..46792287
1: [4849152..51641343]: 46792768..93584959
2: [51641344..98433535]: 93585472..140377663
3: [98433536..131987455]: 140378176..173932095
4: [131987456..145225727]: 173932104..187170375
5: [145225728..192017919]: 187170880..233963071
6: [192017920..209715199]: 233963584..251660863
Signed-off-by: Utako Kusaka <utako@tnes.nec.co.jp>
---
--- xfsprogs-2.8.11-orgn/io/xfs_bmap.sh 2006-06-26 14:01:15.000000000 +0900
+++ xfsprogs-2.8.11/io/xfs_bmap.sh 2006-10-20 12:22:19.771009697 +0900
@@ -14,7 +14,7 @@ do
a) OPTS=$OPTS" -a";;
d) OPTS=$OPTS" -d";;
l) OPTS=$OPTS" -l";;
- n) OPTS=$OPTS" '-n "$OPTARG"'";;
+ n) OPTS=$OPTS" -n "$OPTARG"";;
p) OPTS=$OPTS" -p";;
v) OPTS=$OPTS" -v";;
V) VERSION=true;;
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] xfs_bmap -n fix
2006-10-20 4:18 [PATCH] xfs_bmap -n fix Utako Kusaka
@ 2006-10-20 10:35 ` Lachlan McIlroy
0 siblings, 0 replies; 2+ messages in thread
From: Lachlan McIlroy @ 2006-10-20 10:35 UTC (permalink / raw)
To: Utako Kusaka; +Cc: xfs
Hi Utako,
That's definitely a bug, thanks for the fix.
Lachlan
Utako Kusaka wrote:
> Hi,
>
> This patch fixes the issue that
> "xfs_bmap -n [nnn]" doesn't work correctly.
>
> Example:
> # xfs_io -c "bmap -n 3" test/file2
> test/file2:
> 0: [0..4849151]: 41943136..46792287
> 1: [4849152..51641343]: 46792768..93584959
> 2: [51641344..68418047]: 93585472..110362175
> # xfs_bmap -n 3 test/file2
> test/file2:
> 0: [0..4849151]: 41943136..46792287
> 1: [4849152..51641343]: 46792768..93584959
> 2: [51641344..98433535]: 93585472..140377663
> 3: [98433536..131987455]: 140378176..173932095
> 4: [131987456..145225727]: 173932104..187170375
> 5: [145225728..192017919]: 187170880..233963071
> 6: [192017920..209715199]: 233963584..251660863
>
> Signed-off-by: Utako Kusaka <utako@tnes.nec.co.jp>
> ---
>
> --- xfsprogs-2.8.11-orgn/io/xfs_bmap.sh 2006-06-26 14:01:15.000000000 +0900
> +++ xfsprogs-2.8.11/io/xfs_bmap.sh 2006-10-20 12:22:19.771009697 +0900
> @@ -14,7 +14,7 @@ do
> a) OPTS=$OPTS" -a";;
> d) OPTS=$OPTS" -d";;
> l) OPTS=$OPTS" -l";;
> - n) OPTS=$OPTS" '-n "$OPTARG"'";;
> + n) OPTS=$OPTS" -n "$OPTARG"";;
> p) OPTS=$OPTS" -p";;
> v) OPTS=$OPTS" -v";;
> V) VERSION=true;;
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-10-20 10:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-20 4:18 [PATCH] xfs_bmap -n fix Utako Kusaka
2006-10-20 10:35 ` Lachlan McIlroy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox