Re: [PATCH] (and bad attr2 bug) - pack xfs_sb_t for 64-bit arches

Eric Sandeen
2006-11-20T01:40:50Z

Nathan Scott wrote:
> On Fri, 2006-11-17 at 09:20 -0600, sandeen@sandeen.net wrote:
>>> On Fri, 2006-11-17 at 00:34 -0600, sandeen@sandeen.net wrote:
>>>> and really, now that this is out in the wild, maybe sb_features3
>>>> instead of padding is appropriate, and check both for the attr2
>>>> bit...? :(
>>> Thats not going to work, theres three or four other feature2 bits
>>> preceding attr2 as well.
>>>
>>> The "take a 32 bit systems fs to a 64 bit system" is relatively
>>> uncommon, so I suppose its just something we live with (as we did
>>> with the log recovery issues in that situation for several years).
>> So you think this should not be fixed, then? Because if it -is- fixed
>
> I didn't say that. It should be fixed. Noone will notice though,
> as its not actually biting anyone... (the attr2 problem will not
> be related to this, its gonna be something else).

but it can't just be properly padded in the kernel and leave it at that,
can it? If so won't attr2 filesystems on x86_64 suddenly start
appearing to be attr2?

-Eric