Re: [PATCH] (and bad attr2 bug) - pack xfs_sb_t for 64-bit arches

David Chinner
2007-05-21T07:43:09Z

On Thu, May 17, 2007 at 09:41:40AM -0500, Eric Sandeen wrote:
> Eric Sandeen wrote:
> >see also https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212201
> >
> >Bugzilla Bug 212201: Cannot build sysem with XFS file system.
> >
> >I turned on attr2 in FC6 at nathan's suggestion, for selinux goodness
> >with more efficient xattr space usage.
> >
> >But, many reports that this was totally broken in fc6, on x86_64.
>
> Although it turned out to be a different issue, not the packing issue,
> is the packing/alignment (below) still something that needs to be fixed...?

The problem of the screwed up structure should be fixed. however,
packing the structure is not the correct solution IMO. I think we discussed
the correct fx back when this was first brought up - blacklist the bad
bits in the superblock, do on the fly detection and correction of the problem
and make sure in future that we always leave padding in the structure
so that it is always correctly translated....

Patches are welcome ;)

Cheers,

Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group