From: Eric Sandeen <sandeen@sandeen.net>
To: chatz@melbourne.sgi.com
Cc: David Chinner <dgc@sgi.com>,
Russell Cattelan <cattelan@thebarn.com>,
Tim Shimmin <tes@sgi.com>,
xfs@oss.sgi.com
Subject: Re: [PATCH 1/2] Make stuff static
Date: Wed, 22 Nov 2006 10:13:15 -0600 [thread overview]
Message-ID: <4564771B.4040004@sandeen.net> (raw)
In-Reply-To: <4563D7DD.1060907@melbourne.sgi.com>
David Chatterton wrote:
>
> David Chinner wrote:
>> Comments?
>>
>
> Just reducing xfs_bmapi by 118 bytes makes this worthwhile doesn't it?
>
> Out of interest, what estimated improvement does this have on one of Jesper's
> stacks?
>
> Should we be concerned that there are now more functions with 100 or more bytes?
I don't think we need to worry about that, it is probably in the noise.
There will almost certainly be fallout from this change w.r.t. 4k
stacks. It should probably at least be tested on 4k stacks over a fairly
complex volume setup to see.
Also with respect to stack usage, is there extra stack space used, in
addition to the explicit %esp adjustments, to set up each function call?
IOW is the total more than the sum of the parts? :)
I'm glad to hear that there's no apparent performance penalty....
-eric
next prev parent reply other threads:[~2006-11-22 16:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-29 3:28 [PATCH 1/2] Make stuff static sandeen
2006-10-14 4:31 ` Eric Sandeen
2006-10-16 9:12 ` Timothy Shimmin
2006-10-16 13:49 ` Eric Sandeen
2006-10-16 21:34 ` Eric Sandeen
2006-10-16 23:22 ` David Chinner
2006-10-16 23:55 ` Russell Cattelan
2006-10-17 0:50 ` David Chinner
2006-10-17 1:03 ` Eric Sandeen
2006-10-17 3:09 ` David Chinner
2006-10-17 3:18 ` Nathan Scott
2006-10-18 0:56 ` David Chinner
2006-10-17 7:13 ` Tim Shimmin
2006-10-17 21:57 ` David Chinner
2006-10-17 22:45 ` Russell Cattelan
2006-11-22 0:42 ` David Chinner
2006-11-22 1:09 ` Russell Cattelan
2006-11-22 2:16 ` David Chatterton
2006-11-22 4:24 ` David Chinner
2006-11-22 4:53 ` David Chatterton
2006-11-22 16:13 ` Eric Sandeen [this message]
2006-11-29 7:31 ` David Chinner
2006-11-26 14:05 ` Eric Sandeen
2006-10-18 4:06 ` Timothy Shimmin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4564771B.4040004@sandeen.net \
--to=sandeen@sandeen.net \
--cc=cattelan@thebarn.com \
--cc=chatz@melbourne.sgi.com \
--cc=dgc@sgi.com \
--cc=tes@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox