* [PATCH] Return failure error if something fails in xfs_growfs
@ 2006-12-21 6:15 Barry Naujok
2006-12-21 6:21 ` Nathan Scott
2006-12-21 16:37 ` Eric Sandeen
0 siblings, 2 replies; 3+ messages in thread
From: Barry Naujok @ 2006-12-21 6:15 UTC (permalink / raw)
To: xfs-dev; +Cc: xfs
[-- Attachment #1: Type: text/plain, Size: 100 bytes --]
A very simple patch that return error rather than success if something
fails in xfs_growfs.
Barry.
[-- Attachment #2: growfs_error.diff --]
[-- Type: application/octet-stream, Size: 336 bytes --]
--- a/xfsprogs/growfs/xfs_growfs.c 2006-12-21 17:07:16.000000000 +1100
+++ b/xfsprogs/growfs/xfs_growfs.c 2006-12-21 17:06:16.639597863 +1100
@@ -448,5 +448,5 @@
if (geo.rtextsize != ngeo.rtextsize)
printf(_("realtime extent size changed from %d to %d\n"),
geo.rtextsize, ngeo.rtextsize);
- exit(0);
+ exit(error);
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Return failure error if something fails in xfs_growfs
2006-12-21 6:15 [PATCH] Return failure error if something fails in xfs_growfs Barry Naujok
@ 2006-12-21 6:21 ` Nathan Scott
2006-12-21 16:37 ` Eric Sandeen
1 sibling, 0 replies; 3+ messages in thread
From: Nathan Scott @ 2006-12-21 6:21 UTC (permalink / raw)
To: Barry Naujok; +Cc: xfs-dev, xfs
On Thu, 2006-12-21 at 17:15 +1100, Barry Naujok wrote:
> ...
Makes sense & looks correct in xdiff. :)
cheers.
--
Nathan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Return failure error if something fails in xfs_growfs
2006-12-21 6:15 [PATCH] Return failure error if something fails in xfs_growfs Barry Naujok
2006-12-21 6:21 ` Nathan Scott
@ 2006-12-21 16:37 ` Eric Sandeen
1 sibling, 0 replies; 3+ messages in thread
From: Eric Sandeen @ 2006-12-21 16:37 UTC (permalink / raw)
To: Barry Naujok; +Cc: xfs-dev, xfs
Barry Naujok wrote:
> A very simple patch that return error rather than success if something
> fails in xfs_growfs.
>
> Barry.
Try as I might to follow the grand linux tradition of finding some minor
stylistic point to complain about (whitespace, formatting, choice of
variable names, etc) I could not. So, looks good to me. :-)
-Eric
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-12-21 16:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-12-21 6:15 [PATCH] Return failure error if something fails in xfs_growfs Barry Naujok
2006-12-21 6:21 ` Nathan Scott
2006-12-21 16:37 ` Eric Sandeen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox