Re: merged patches

Re: merged patches

[Lachlan McIlroy]

Eric Sandeen wrote:
> Hi Lachlan, thanks for merging some of my tidy-up patches.  :)
> 
> A couple things -
> 
> I never saw the take messages go by the external list, just noticed them
> after a cvs update and an attempt to sync up my patchset.  Can you guys
> please send the take messages externally too?  It makes it much easier
> to keep up with what's going on, for those interested.
I sent the TAKE messages to xfs@oss.sgi.com, xfs-dev@sgi.com and to
Bugworks.  We've had problems with email traffic to oss disappearing
or taking up to 4 weeks to appear!

> 
> Also, please don't strip out the Signed-off-by: lines in contributed
> patches; that authorship information should stay with the patch.  Feel
> free to add signed-off-by or reviewed-by but the original signed-off-by
> line shouldn't be removed...
Sorry about that, I didn't know about the signed-off-by thingy.

Re: merged patches

[Lachlan McIlroy]

Eric Sandeen wrote:
> Eric Sandeen wrote:
> 
>>Hi Lachlan, thanks for merging some of my tidy-up patches.  :)
>>
>>A couple things -
>>
>>I never saw the take messages go by the external list, just noticed them
>>after a cvs update and an attempt to sync up my patchset.  Can you guys
>>please send the take messages externally too?  It makes it much easier
>>to keep up with what's going on, for those interested.
>>
>>Also, please don't strip out the Signed-off-by: lines in contributed
>>patches; that authorship information should stay with the patch.  Feel
>>free to add signed-off-by or reviewed-by but the original signed-off-by
>>line shouldn't be removed...
>>
>>Thanks,
>>-Eric
>>
> 
> 
> BTW here's the original motivation for the Signed-off-by line:
> 
> http://kerneltrap.org/node/3180

Thanks.

Re: merged patches

[David Chatterton]

Lachlan,

I think this page
http://asg.melbourne.sgi.com/xfs/rampup/xfs_to_linus.shtml
needs to rewritten to make it clear about
- signed off by
- the one line at the start of the overall change description
- cc'ing xfs@oss.sgi.com
- anything else?

The title of the page is not right either, we have other pages now
describing how to push stuff to linus, and others talking about how to
use git.

Could you have a go at this?

Thanks,

David


Lachlan McIlroy wrote:
> Eric Sandeen wrote:
>> Hi Lachlan, thanks for merging some of my tidy-up patches.  :)
>>
>> A couple things -
>>
>> I never saw the take messages go by the external list, just noticed them
>> after a cvs update and an attempt to sync up my patchset.  Can you guys
>> please send the take messages externally too?  It makes it much easier
>> to keep up with what's going on, for those interested.
> I sent the TAKE messages to xfs@oss.sgi.com, xfs-dev@sgi.com and to
> Bugworks.  We've had problems with email traffic to oss disappearing
> or taking up to 4 weeks to appear!
> 
>>
>> Also, please don't strip out the Signed-off-by: lines in contributed
>> patches; that authorship information should stay with the patch.  Feel
>> free to add signed-off-by or reviewed-by but the original signed-off-by
>> line shouldn't be removed...
> Sorry about that, I didn't know about the signed-off-by thingy.

-- 
David Chatterton
XFS Engineering Manager
SGI Australia