From: Donald Douwsma <donaldd@sgi.com>
To: Utako Kusaka <utako@tnes.nec.co.jp>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] fix the grace time in xfs_quota
Date: Fri, 16 Feb 2007 16:31:59 +1100 [thread overview]
Message-ID: <45D541CF.2070106@sgi.com> (raw)
In-Reply-To: <200702150739.AA04964@TNESG9305.tnes.nec.co.jp>
Hi Utako,
I was unable to reproduce these results internally (sgi-xfsprogs-2.8.16-1sgi100b2chatz).
But I think your patch looks good, these really should be time_t's.
$ sudo /usr/sbin/xfs_quota -xc report /mnt/test
User quota on /mnt/test (/dev/sdb5)
Blocks
User ID Used Soft Hard Warn/Grace
---------- --------------------------------------------------
bin 168 0 0 00 [--------]
games 608 0 0 00 [--------]
root 125948 0 0 00 [0 days]
donaldd 15000 10240 20480 00 [00:00:11]
$ sudo /usr/sbin/xfs_quota -xc report /mnt/test
User quota on /mnt/test (/dev/sdb5)
Blocks
User ID Used Soft Hard Warn/Grace
---------- --------------------------------------------------
bin 168 0 0 00 [--------]
games 608 0 0 00 [--------]
root 125948 0 0 00 [0 days]
donaldd 15000 10240 20480 00 [0 days]
Thanks for the patch,
Donald
Utako Kusaka wrote:
...
> Example:
> xfs_quota> report
> User quota on /home/utako/mpnt (/dev/sda6)
> Blocks
> User ID Used Soft Hard Warn/Grace
> ---------- --------------------------------------------------
> root 3145728 1000 2000 00 [--none--]
> utako 1000 1000 2000 00 [00:00:4294967286] <--
>
> Group quota on /home/utako/mpnt (/dev/sda6)
> Blocks
> Group ID Used Soft Hard Warn/Grace
> ---------- --------------------------------------------------
> root 3145728 0 0 00 [--------]
> users 1000 0 0 00 [--------]
> Signed-off-by: Utako Kusaka <utako@tnes.nec.co.jp>
> ---
>
> --- xfsprogs-2.8.18-orgn/quota/quota.h 2006-12-13 13:57:23.000000000 +0900
> +++ xfsprogs-2.8.18/quota/quota.h 2007-02-15 11:51:20.000000000 +0900
> @@ -49,7 +49,7 @@ enum {
> */
> extern char *type_to_string(uint __type);
> extern char *form_to_string(uint __form);
> -extern char *time_to_string(__uint32_t __time, uint __flags);
> +extern char *time_to_string(time_t __time, uint __flags);
> extern char *bbs_to_string(__uint64_t __v, char *__c, uint __size);
> extern char *num_to_string(__uint64_t __v, char *__c, uint __size);
> extern char *pct_to_string(__uint64_t __v, __uint64_t __t, char *__c, uint __s);
>
>
> --- xfsprogs-2.8.18-orgn/quota/util.c 2006-12-13 13:57:23.000000000 +0900
> +++ xfsprogs-2.8.18/quota/util.c 2007-02-15 11:51:51.000000000 +0900
> @@ -29,7 +29,7 @@
>
> char *
> time_to_string(
> - __uint32_t origin,
> + time_t origin,
> uint flags)
> {
> static char timestamp[32];
>
>
prev parent reply other threads:[~2007-02-16 5:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-15 7:39 [PATCH] fix the grace time in xfs_quota Utako Kusaka
2007-02-16 5:31 ` Donald Douwsma [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45D541CF.2070106@sgi.com \
--to=donaldd@sgi.com \
--cc=utako@tnes.nec.co.jp \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox