public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Shailendra Tripathi <stripathi@agami.com>
To: Barry Naujok <bnaujok@melbourne.sgi.com>
Cc: xfs@oss.sgi.com, xfs-dev@sgi.com
Subject: Re: [PATCH] xfs_repair doesn't detect corrupt btree roots in nodes
Date: Fri, 09 Mar 2007 11:29:18 +0530	[thread overview]
Message-ID: <45F0F7B6.9070406@agami.com> (raw)
In-Reply-To: <200703090358.OAA12270@larry.melbourne.sgi.com>

Looks ok to me.

Can you test if it works by manually corrupting some B+Tree using xfs_db 
(or in fact, you can write a small program which does so. You can just 
write a program which reads the location on the disk directly, modify 
the 512 size sector corresponding to these with some selected fields and 
write them out.)

Try the code when major B+Trees are corrupted --> AGI /BCNTi/BSIZE tree.

-shailendra

Barry Naujok wrote:
> Ping?
> 
> 
>>-----Original Message-----
>>From: xfs-bounce@oss.sgi.com [mailto:xfs-bounce@oss.sgi.com] 
>>On Behalf Of Barry Naujok
>>Sent: Thursday, 22 February 2007 12:33 PM
>>To: xfs@oss.sgi.com
>>Cc: xfs-dev@sgi.com
>>Subject: [PATCH] xfs_repair doesn't detect corrupt btree 
>>roots in nodes
>>
>>The attached patch detect invalid btree root field (numrecs = 
>>0, levels >
>>permissable value).
>>
>>The patch also does some cleanup with the level and numrecs 
>>usage for the
>>process_btinode function.
>>
>>

      reply	other threads:[~2007-03-09  6:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-22  1:32 [PATCH] xfs_repair doesn't detect corrupt btree roots in nodes Barry Naujok
2007-03-09  3:59 ` Barry Naujok
2007-03-09  5:59   ` Shailendra Tripathi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45F0F7B6.9070406@agami.com \
    --to=stripathi@agami.com \
    --cc=bnaujok@melbourne.sgi.com \
    --cc=xfs-dev@sgi.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox