From: Vlad Apostolov <vapo@sgi.com>
To: xfs-dev <xfs-dev@sgi.com>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Review: do not hold dm_reg_lock spinlock when calling dm_add_fsys_entry()
Date: Fri, 30 Mar 2007 11:34:21 +1000 [thread overview]
Message-ID: <460C691D.9080100@sgi.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 104 bytes --]
dm_reg_lock spinlock has been held when calling dm_add_fsys_entry()
Attached is a fix.
Regards,
Vlad
[-- Attachment #2: sleeping-in-atomic-in-dmapi.patch --]
[-- Type: text/x-patch, Size: 525 bytes --]
Index: linux/fs/dmapi/dmapi_register.c
===================================================================
--- linux.orig/fs/dmapi/dmapi_register.c
+++ linux/fs/dmapi/dmapi_register.c
@@ -252,6 +252,7 @@ dm_add_fsys_entry(
fsrp->fr_next = dm_registers;
dm_registers = fsrp;
dm_fsys_cnt++;
+ mutex_spinunlock(&dm_reg_lock, lc);
#ifdef CONFIG_PROC_FS
{
char buf[100];
@@ -262,7 +263,6 @@ dm_add_fsys_entry(
entry->owner = THIS_MODULE;
}
#endif
- mutex_spinunlock(&dm_reg_lock, lc);
return(0);
}
reply other threads:[~2007-03-30 1:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=460C691D.9080100@sgi.com \
--to=vapo@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox