From: Eric Sandeen <sandeen@sandeen.net>
To: David Chinner <dgc@sgi.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs-dev <xfs-dev@sgi.com>,
xfs-oss <xfs@oss.sgi.com>
Subject: Re: review: allocate alloc args
Date: Tue, 24 Apr 2007 12:27:06 -0500 [thread overview]
Message-ID: <462E3DEA.1070907@sandeen.net> (raw)
In-Reply-To: <20070423223257.GM32602149@melbourne.sgi.com>
David Chinner wrote:
> On Mon, Apr 23, 2007 at 10:22:01PM +0100, Christoph Hellwig wrote:
>> I don't like doing even more dynamic allocations that deep
>> down in the stack.
>
> I'm not a big fan of it either, but I don't really see any other
> option here. We need a bunch of temporary space for structures
> *somewhere*, and if there isn't enough stack space then it's
> got to come frm somewhere else.
How about a global array of such structures which can be accessed as
needed. :)
/me runs
I think Christoph is on the right track here; find ways to make the
functions use less stack down the chain, either by breaking them up,
breaking up the large structures into what's actually needed, or
something along those types of refactoring lines... I'm so burned out on
this stuff though. :)
-Eric
next prev parent reply other threads:[~2007-04-24 17:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-19 7:32 review: allocate alloc args David Chinner
2007-04-23 21:22 ` Christoph Hellwig
2007-04-23 22:32 ` David Chinner
2007-04-24 17:27 ` Eric Sandeen [this message]
2007-04-25 23:11 ` David Chinner
2007-04-26 1:41 ` Eric Sandeen
2007-04-26 18:06 ` Mike Gigante
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=462E3DEA.1070907@sandeen.net \
--to=sandeen@sandeen.net \
--cc=dgc@sgi.com \
--cc=hch@infradead.org \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox