public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Vlad Apostolov <vapo@sgi.com>
To: David Chinner <dgc@sgi.com>
Cc: xfs-dev <xfs-dev@sgi.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: Review: xfs_bmapi does not update previous extent pointer correctly
Date: Mon, 04 Jun 2007 15:26:27 +1000	[thread overview]
Message-ID: <4663A283.2030205@sgi.com> (raw)
In-Reply-To: <20070604051944.GQ85884050@sgi.com>

It is looking good Dave,

Regards,
Vlad

David Chinner wrote:
> When looping across multiple extents, xfs_bmapi will fail to
> update the previous extent pointer which is used in subsequent
> loops.
>
> As a result, we can end up with the second loop in xfs_bmapi trying
> to use an incorrect previous extent pointer and assert failures or
> corrupted in-memory extent lists will result.
>
> Correctly update the previous extent at the end of each loop so that
> we DTRT when processing multiple map requests.
>
> Cheers,
>
> Dave.
>   

      reply	other threads:[~2007-06-04  5:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-04  5:19 Review: xfs_bmapi does not update previous extent pointer correctly David Chinner
2007-06-04  5:26 ` Vlad Apostolov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4663A283.2030205@sgi.com \
    --to=vapo@sgi.com \
    --cc=dgc@sgi.com \
    --cc=xfs-dev@sgi.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox