From: Tim Shimmin <tes@sgi.com>
To: xfs-dev@sgi.com
Cc: xfs@oss.sgi.com
Subject: review: xfs_growfs_data_private() not logging agf length change
Date: Thu, 07 Jun 2007 17:03:11 +1000 [thread overview]
Message-ID: <4667ADAF.7000904@sgi.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 686 bytes --]
Looks like we forgot to log the agf_length change here.
(cut 'n' pasted patch)
--Tim
===========================================================================
Index: fs/xfs/xfs_fsops.c
===========================================================================
--- a/fs/xfs/xfs_fsops.c 2007-04-17 18:02:46.000000000 +1000
+++ b/fs/xfs/xfs_fsops.c 2007-04-17 17:59:44.467987572 +1000
@@ -328,6 +328,7 @@ xfs_growfs_data_private(
be32_add(&agf->agf_length, new);
ASSERT(be32_to_cpu(agf->agf_length) ==
be32_to_cpu(agi->agi_length));
+ xfs_alloc_log_agf(tp, bp, XFS_AGF_LENGTH);
/*
* Free the new space.
*/
[-- Attachment #2: agf_length.patch --]
[-- Type: text/plain, Size: 388 bytes --]
--- .pc/agf_length.patch/fs/xfs/xfs_fsops.c 2007-06-07 16:19:27.000000000 +1000
+++ fs/xfs/xfs_fsops.c 2007-06-07 16:23:41.302363734 +1000
@@ -332,6 +332,7 @@ xfs_growfs_data_private(
be32_add(&agf->agf_length, new);
ASSERT(be32_to_cpu(agf->agf_length) ==
be32_to_cpu(agi->agi_length));
+ xfs_alloc_log_agf(tp, bp, XFS_AGF_LENGTH);
/*
* Free the new space.
*/
next reply other threads:[~2007-06-07 7:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-07 7:03 Tim Shimmin [this message]
2007-06-07 7:30 ` review: xfs_growfs_data_private() not logging agf length change David Chinner
2007-06-07 12:18 ` Christoph Hellwig
2007-06-07 12:49 ` David Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4667ADAF.7000904@sgi.com \
--to=tes@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox