From: Eric Sandeen <sandeen@sandeen.net>
To: David Chinner <dgc@sgi.com>
Cc: xfs@oss.sgi.com, iusty@k1024.org
Subject: Re: [PATCH] Implement shrink of empty AGs
Date: Mon, 11 Jun 2007 23:25:47 -0500 [thread overview]
Message-ID: <466E204B.8060608@sandeen.net> (raw)
In-Reply-To: <20070612024025.GM86004887@sgi.com>
David Chinner wrote:
> On Sun, Jun 10, 2007 at 06:40:14PM +0200, Iustin Pop wrote:
...
>> + /* FIXME: why is this flag unconditionally set in growfs? */
>> + mp->m_flags |= XFS_MOUNT_32BITINODES;
>> + nagimax = xfs_initialize_perag(XFS_MTOVFS(mp), mp, nagcount);
> good question. I don't think it should be there but I'll have to
> do some digging....
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_fsops.c#rev1.72
Thu Dec 6 19:26:09 2001 UTC (5 years, 6 months ago) by lord
Add in the 32 bit inode mount flag before re initializing the perag
structures in growfs.
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_fsops.c.diff?r1=1.71;r2=1.72
but, it seems harmless because it immediately calls xfs_initialize_perag
which does:
/* Clear the mount flag if no inode can overflow 32 bits
* on this filesystem, or if specifically requested..
*/
if ((mp->m_flags & XFS_MOUNT_32BITINOOPT) && ino > max_inum) {
mp->m_flags |= XFS_MOUNT_32BITINODES;
} else {
mp->m_flags &= ~XFS_MOUNT_32BITINODES;
}
so I think it sets it (or clears it) properly in any case. I'd probably
remove the setting before initialize_perag though as it's superfluous...
that was added after steve's change...
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_mount.c#rev1.335
Mon Sep 8 05:46:42 2003 UTC (3 years, 9 months ago) by nathans
Add inode64 mount option; fix case where growfs can push 32 bit inodes
into 64 bit space accidentally - both changes originally from IRIX
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_mount.c.diff?r1=1.334;r2=1.335
(previously it would always clear the flag if max inode was < 32 bits..)
... so yeah, looks like the setting in question can/should go.
-Eric
next prev parent reply other threads:[~2007-06-12 4:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-10 16:40 [PATCH] Implement shrink of empty AGs Iustin Pop
2007-06-12 2:40 ` David Chinner
2007-06-12 4:25 ` Eric Sandeen [this message]
2007-06-14 6:01 ` Iustin Pop
2007-06-14 9:00 ` David Chinner
2007-06-14 20:55 ` Iustin Pop
2007-06-14 22:16 ` David Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=466E204B.8060608@sandeen.net \
--to=sandeen@sandeen.net \
--cc=dgc@sgi.com \
--cc=iusty@k1024.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox