Re: [PATCH] remove hard-coded fnames from tracing functions

David Chinner
2007-06-25T10:49:28Z

On Sun, Jun 24, 2007 at 11:53:03PM -0500, Eric Sandeen wrote:
> Eric Sandeen wrote:
> > This has been on my stack a while, still compiles clean but feel free
> > to double-check. :-)
> >
> > xfs_alloc.c | 53 ++--------
> > xfs_bmap.c | 266 +++++++++++++++++++++++--------------------------------
> > xfs_bmap.h | 6 -
> > xfs_bmap_btree.c | 88 +++---------------
> > xfs_inode.c | 8 -
> > 5 files changed, 149 insertions(+), 272 deletions(-)
> >
> > ---------------
> >
> > Remove the hardcoded "fnames" for tracing, and just embed
> > them in tracing macros via __FUNCTION__. Kills a lot of #ifdefs
> > too.
>
> Hm... guess I did send this one already, but don't see it in cvs...
> Dave, is it in your stack yet?

<sigh>

It got as far as my incoming directory. I even remember reviewing it,
and then I forgot to import the patch. My bad.

I'll add it now.

Cheers,

Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group