* [PATCH] fix constness warning in dmapi
@ 2007-07-14 16:09 Christoph Hellwig
2007-07-14 16:45 ` Eric Sandeen
0 siblings, 1 reply; 2+ messages in thread
From: Christoph Hellwig @ 2007-07-14 16:09 UTC (permalink / raw)
To: xfs
File operations are const now so make sure the dmapi code propagates
this properly.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: linux-2.6-xfs/fs/dmapi/dmapi_kern.h
===================================================================
--- linux-2.6-xfs.orig/fs/dmapi/dmapi_kern.h 2007-07-14 16:08:31.000000000 +0200
+++ linux-2.6-xfs/fs/dmapi/dmapi_kern.h 2007-07-14 16:08:41.000000000 +0200
@@ -79,7 +79,7 @@ struct filesystem_dmapi_operations {
int (*get_fsys_vector)(struct super_block *sb, void *addr);
int (*fh_to_inode)(struct super_block *sb, struct inode **ip,
dm_fid_t *fid);
- struct file_operations * (*get_invis_ops)(struct inode *ip);
+ const struct file_operations * (*get_invis_ops)(struct inode *ip);
int (*inode_to_fh)(struct inode *ip, dm_fid_t *fid,
dm_fsid_t *fsid );
void (*get_fsid)(struct super_block *sb, dm_fsid_t *fsid);
Index: linux-2.6-xfs/fs/xfs/dmapi/xfs_dm_fsops.c
===================================================================
--- linux-2.6-xfs.orig/fs/xfs/dmapi/xfs_dm_fsops.c 2007-07-14 16:07:47.000000000 +0200
+++ linux-2.6-xfs/fs/xfs/dmapi/xfs_dm_fsops.c 2007-07-14 16:07:55.000000000 +0200
@@ -49,7 +49,7 @@
#include "xfs_dm.h"
-STATIC struct file_operations *
+STATIC const struct file_operations *
xfs_dm_get_invis_ops(
struct inode *ip)
{
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] fix constness warning in dmapi
2007-07-14 16:09 [PATCH] fix constness warning in dmapi Christoph Hellwig
@ 2007-07-14 16:45 ` Eric Sandeen
0 siblings, 0 replies; 2+ messages in thread
From: Eric Sandeen @ 2007-07-14 16:45 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: xfs
Christoph Hellwig wrote:
> File operations are const now so make sure the dmapi code propagates
> this properly.
ACK. Surprised that was still there :)
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: linux-2.6-xfs/fs/dmapi/dmapi_kern.h
> ===================================================================
> --- linux-2.6-xfs.orig/fs/dmapi/dmapi_kern.h 2007-07-14 16:08:31.000000000 +0200
> +++ linux-2.6-xfs/fs/dmapi/dmapi_kern.h 2007-07-14 16:08:41.000000000 +0200
> @@ -79,7 +79,7 @@ struct filesystem_dmapi_operations {
> int (*get_fsys_vector)(struct super_block *sb, void *addr);
> int (*fh_to_inode)(struct super_block *sb, struct inode **ip,
> dm_fid_t *fid);
> - struct file_operations * (*get_invis_ops)(struct inode *ip);
> + const struct file_operations * (*get_invis_ops)(struct inode *ip);
> int (*inode_to_fh)(struct inode *ip, dm_fid_t *fid,
> dm_fsid_t *fsid );
> void (*get_fsid)(struct super_block *sb, dm_fsid_t *fsid);
> Index: linux-2.6-xfs/fs/xfs/dmapi/xfs_dm_fsops.c
> ===================================================================
> --- linux-2.6-xfs.orig/fs/xfs/dmapi/xfs_dm_fsops.c 2007-07-14 16:07:47.000000000 +0200
> +++ linux-2.6-xfs/fs/xfs/dmapi/xfs_dm_fsops.c 2007-07-14 16:07:55.000000000 +0200
> @@ -49,7 +49,7 @@
> #include "xfs_dm.h"
>
>
> -STATIC struct file_operations *
> +STATIC const struct file_operations *
> xfs_dm_get_invis_ops(
> struct inode *ip)
> {
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-07-14 16:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-14 16:09 [PATCH] fix constness warning in dmapi Christoph Hellwig
2007-07-14 16:45 ` Eric Sandeen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox