From: Michael Nishimoto <miken@agami.com>
To: XFS Mailing List <xfs@oss.sgi.com>
Subject: Couple of code comments
Date: Tue, 24 Jul 2007 18:59:53 -0700 [thread overview]
Message-ID: <46A6AE99.3000502@agami.com> (raw)
Hi,
I've got a couple of code comments. In xfs_write, there is a
call to bhv_vop_flushinval_pages(). It appears that this function call
is not needed because the call to generic_file_direct_write() done
later in xfs_write does the same work.
generic_file_direct_write -> generic_file_direct_IO ->
(filemap_write_and_wait + invalidate_inode_pages2_range)
bhv_vop_flushinval_pages -> fs_flushinval_pages ->
(filemap_write_and_wait + truncate_inode_pages)
The code isn't exactly the same, but it appears to do the same work.
Also, within xfs_swap_extents() the code fixes up on-disk inode block
counts, but doesn't change the block counts for the Linux inode.
Comments?
Michael
next reply other threads:[~2007-07-25 1:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-25 1:59 Michael Nishimoto [this message]
2007-07-25 3:03 ` Couple of code comments David Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46A6AE99.3000502@agami.com \
--to=miken@agami.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox