Re: RFC: log record CRC validation

Michael Nishimoto
2007-07-26T17:53:16Z

Mark Goodwin wrote:

>
> David Chinner wrote:
> >
> > The next question is the hard one. What do we do when we detect
> > a log record CRC error? Right now it just warns and sets a flag
> > in the log. I think it should probably prevent log replay from
> > replaying past this point (i.e. trim the head back to the last
> > good log record) but I'm not sure what the best thing to do here.
> >
> > Comments?
>
> 1. perhaps use a new flag XLOG_CRC_MISMATCH instead of
> XLOG_CHKSUM_MISMATCH
> 2. is there (or could there be if we added it), correction for n-bit
> errors?
>
> -- Mark
>
I don't see the original message in the archives. Is CRC checking being
added to xfs log data? If so, what data has been collected to show that
this needs to be added?

thanks,

Michael