From: Donald Douwsma <donaldd@sgi.com>
To: David Chinner <dgc@sgi.com>
Cc: xfs-dev <xfs-dev@sgi.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: Review: demand reaping of filestreams objects
Date: Mon, 30 Jul 2007 14:49:45 +1000 [thread overview]
Message-ID: <46AD6DE9.5090806@sgi.com> (raw)
In-Reply-To: <20070723021051.GV12413810@sgi.com>
David Chinner wrote:
> Now that the problems with cancel_rearming_delayed_workqueue()
> deadlocks have been fixed, we can go back to only running
> the reaping when we have objects to time out. This prevents
> the reaper from running when there is nothing to do.
>
> Cheers,
>
> Dave.
You probably meant to remove the printk's,
@@ -206,8 +206,12 @@ _xfs_mru_cache_list_insert(
...
+ if (!mru->queued) {
+ printk("reaper started\n");
@@ -271,29 +275,27 @@ _xfs_mru_cache_reap(
+ } else
+ printk("reaper stopped\n");
Apart from that it looks good, much simpler.
Don
next prev parent reply other threads:[~2007-07-30 4:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-23 2:10 Review: demand reaping of filestreams objects David Chinner
2007-07-30 4:49 ` Donald Douwsma [this message]
2007-07-30 5:06 ` David Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46AD6DE9.5090806@sgi.com \
--to=donaldd@sgi.com \
--cc=dgc@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox