Re: [PATCH V2] make xfs stats Kconfigurable

[Eric Sandeen <sandeen@sandeen.net>]

Christoph Hellwig wrote:
> On Sun, Aug 19, 2007 at 12:21:09PM -0500, Eric Sandeen wrote:
>> Oops, typo in Makefile (CONFIG_XFS_STAT vs _STATS).
>>
>> ----
>>
>>
>> xfs stats are already optional based on CONFIG_PROC_FS, and there
>> is already a (never-set) macro XFS_STATS_OFF which can turn them
>> off.  Making it a configurable option, if I turn them off I can
>> get a little stack savings on x86, gcc 4.1:
> 
> Why would we want to disable the statistics?

To save a little stack space.  :)  *shrug*

This one's not so critical.  FWIW, JFS has configurable stats, and I
think an upcoming jbd patch adds (config-optional) stats.

OTOH when are stats really used outside of sgi?  Though I suppose
occasionally they'd be useful in field debugging.

*shrug* this one may not be worth it; I won't be heartbroken if it
doesn't go in... it helps a tiny bit on the stack side.

-Eric

>> +	config XFS_STATS
> 
> Everywhere else the config statement is not indented, so it probably
> shouldn't be here either.
>