public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Lachlan McIlroy <lachlan@sgi.com>
To: Christian Kujau <lists@nerdbynature.de>
Cc: xfs@oss.sgi.com
Subject: Re: lockdep annotations?
Date: Mon, 03 Sep 2007 12:46:30 +1000	[thread overview]
Message-ID: <46DB7586.7040309@sgi.com> (raw)
In-Reply-To: <alpine.DEB.0.999.0709012300030.6640@sheep.housecafe.de>

This is a locking inversion between the iolock and iprune_mutex.  I
hadn't seen this one before.  Was your system running low on memory
at the time?

We can't drop the iolock in the write path so we'll have to avoid
acquiring the iolock in xfs_ireclaim() which means we'll need another
way to synchronise with xfs_sync_inodes().

Thanks for pointing this one out.

Lachlan

Christian Kujau wrote:
> Hi,
> 
> I try to follow -rc kernels and just upgraded to 2.6.23-rc5 and I still 
> see: "INFO: possible circular locking dependency detected". Out of 
> curiosity: (when) will these warnings be addressed? I mean, suits me for 
> enabling CONFIG_LOCKDEP in the first place, but the only warnings I get 
> is still xfs :)
> 
> FWIW, full log is here: 
> http://nerdbynature.de/bits/2.6.23-rc5/messages_2.6.23-rc5
> 
> Thanks,
> Christian.

  reply	other threads:[~2007-09-03  2:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-01 21:06 lockdep annotations? Christian Kujau
2007-09-03  2:46 ` Lachlan McIlroy [this message]
2007-09-03  6:33   ` Christian Kujau
2007-09-03  9:01   ` David Chinner
2007-09-04  0:51     ` Lachlan McIlroy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46DB7586.7040309@sgi.com \
    --to=lachlan@sgi.com \
    --cc=lists@nerdbynature.de \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox