From: Eric Sandeen <sandeen@sandeen.net>
To: Bhagi rathi <jahnu77@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>, xfs@oss.sgi.com
Subject: Re: [PATCH] remove dead SYNC_BDFLUSH case in xfs_sync_inodes
Date: Sun, 09 Sep 2007 16:37:37 -0500 [thread overview]
Message-ID: <46E467A1.7030400@sandeen.net> (raw)
In-Reply-To: <cc7060690709091243y4caab0fat85f189d7ce4d6b31@mail.gmail.com>
Bhagi rathi wrote:
> vfs_sync_worker calls with SYNC_BDFLUSH. xfssyncd can call this. I might be
> missing something
> if this is not used.
>
> Thanks,
> -Saradhi.
My eyes glazed over it too, but in xfs_syncsub as hch pointed out to me:
if (flags & (SYNC_ATTR|SYNC_DELWRI)) {
if (flags & SYNC_BDFLUSH)
xfs_finish_reclaim_all(mp, 1);
else
error = xfs_sync_inodes(mp, flags, bypassed);
}
so it won't be called with that flag.
-Eric
next prev parent reply other threads:[~2007-09-09 21:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-09 15:42 [PATCH] remove dead SYNC_BDFLUSH case in xfs_sync_inodes Christoph Hellwig
2007-09-09 19:43 ` Bhagi rathi
2007-09-09 21:37 ` Eric Sandeen [this message]
2007-09-10 4:54 ` Bhagi rathi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46E467A1.7030400@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@lst.de \
--cc=jahnu77@gmail.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox