From: Eric Sandeen <sandeen@sandeen.net>
To: xfs-oss <xfs@oss.sgi.com>
Subject: [PATCH SERIES] untangle spinlock macros
Date: Tue, 11 Sep 2007 00:05:34 -0500 [thread overview]
Message-ID: <46E6221E.803@sandeen.net> (raw)
I have a series of patches at
http://sandeen.net/xfs-patches/patches-spinlock-unobfuscate.tar.bz2
to get rid of the macros upon macros hiding xfs' use of spinlocks, via
for example AIL_LOCK->mutex_spinlock->spin_lock. This also gets rid of
the unused "cookie" variables declared via SPLDECL(s) and other
open-coded unsigned long s; declarations.
patches in the tarball, broken out by lock as requested a while
ago by dgc:
unwrap_AIL_LOCK
unwrap_LOG_LOCK
unwrap_GRANT_LOCK
unwrap_XFS_DQ_PINUNLOCK
unwrap_pagb_lock
unwrap_xfs_dabuf_global_lock
unwrap_mru_lock
unwrap_XFS_SB_LOCK
no_kt_lock
cleanup_lock_goop
Patches have comments/descriptions/signed-off lines in them.
By the end of the series, spin.h is almost empty, only spin_lock_init /
spinlock_destroy are left, and could maybe even be pulled out.... wasn't
sure how far to go. Since the kernel has a mutex_destroy, I wonder if
spinlocks will ever get similar treatment... anyway....
I can post them to the list individually if preferred... though it's
fairly mechanical and not terribly interesting...
Thanks,
-Eric
next reply other threads:[~2007-09-11 5:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-11 5:05 Eric Sandeen [this message]
2007-09-12 1:06 ` [PATCH SERIES] untangle spinlock macros Lachlan McIlroy
2007-09-12 1:35 ` Eric Sandeen
2007-09-12 5:50 ` Lachlan McIlroy
2007-09-12 14:32 ` Eric Sandeen
2007-09-12 1:51 ` Donald Douwsma
2007-09-12 1:55 ` Eric Sandeen
2007-09-12 2:07 ` Eric Sandeen
2007-09-12 6:04 ` Lachlan McIlroy
2007-09-12 8:29 ` Christoph Hellwig
2007-09-13 3:02 ` Eric Sandeen
2007-09-21 21:04 ` Russell Cattelan
2007-09-13 3:04 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46E6221E.803@sandeen.net \
--to=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox