From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@lst.de>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 5/4] simplify xfs_create/mknod/symlink prototype
Date: Fri, 14 Sep 2007 13:31:00 -0500 [thread overview]
Message-ID: <46EAD364.7060305@sandeen.net> (raw)
In-Reply-To: <20070914163041.GG7110@lst.de>
Christoph Hellwig wrote:
> (sorry, go the patch numbering one off)
>
> Simplify the prototype for xfs_create/xfs_mkdir/xfs_symlink by not
> passing down a bhv_vattr_t that just hogs stack space. Instead pass
> down the mode in a mode_t and in case of xfs_crate the rdev as a scalar
> type aswell.
With this whole patch series, I see these stack reductions on my x86
box, nice!
--- before 2007-09-14 06:41:25.000000000 -0500
+++ after 2007-09-14 06:42:25.000000000 -0500
-vn_revalidate [xfs]: 100
+vn_revalidate [xfs]: 4
-xfs_bmbt_delrec [xfs]: 212
+xfs_bmbt_delrec [xfs]: 204
-xfs_free_file_space [xfs]: 196
+xfs_free_file_space [xfs]: 188
+xfs_ioc_fsgetxattr [xfs]: 28
-xfs_ioctl [xfs]: 64
+xfs_ioctl [xfs]: 68
-xfs_symlink [xfs]: 240
+xfs_symlink [xfs]: 256
-xfs_validate_fields [xfs]: 4
+xfs_validate_fields [xfs]: 8
-xfs_vn_getattr [xfs]: 104
+xfs_vn_getattr [xfs]: 12
-xfs_vn_link [xfs]: 108
+xfs_vn_link [xfs]: 8
-xfs_vn_mknod [xfs]: 128
+xfs_vn_mknod [xfs]: 32
-xfs_vn_rename [xfs]: 108
-xfs_vn_rmdir [xfs]: 104
+xfs_vn_rename [xfs]: 8
-xfs_vn_symlink [xfs]: 120
+xfs_vn_symlink [xfs]: 20
-xfs_vn_unlink [xfs]: 104
next prev parent reply other threads:[~2007-09-14 18:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-14 16:30 [PATCH 5/4] simplify xfs_create/mknod/symlink prototype Christoph Hellwig
2007-09-14 18:31 ` Eric Sandeen [this message]
2007-09-14 18:34 ` Eric Sandeen
2007-09-14 22:05 ` Christoph Hellwig
2007-09-15 3:27 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46EAD364.7060305@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox