Re: [PATCH 1/4] simplify validata_fields

Christoph Hellwig
2007-09-18T03:56:20Z

On Tue, Sep 18, 2007 at 01:56:01PM +1000, Lachlan McIlroy wrote:
> Can we drop the i_size_read() check and just call i_size_write()?
> The work we may not do by not calling i_size_write() we have to do
> in i_size_read() anyway, sometimes doing the work twice. And we
> get to lose another stack variable.

Sounds good to me, but I'd prefer to keep it in a separate patch
so this is just the mechanical removal of the xfs_getattr call.

I'll send a separate patch for it today or tomorrow.