From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: with ECARTIS (v1.0.0; list xfs); Wed, 19 Sep 2007 11:18:48 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com [66.187.233.31]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with ESMTP id l8JIIfuw003441 for ; Wed, 19 Sep 2007 11:18:43 -0700 Message-ID: <46F16752.1090702@sandeen.net> Date: Wed, 19 Sep 2007 13:15:46 -0500 From: Eric Sandeen MIME-Version: 1.0 Subject: Re: [PATCH] kill XFS_INOBT_IS_FREE_DISK References: <20070919161202.GA18130@lst.de> In-Reply-To: <20070919161202.GA18130@lst.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com List-Id: xfs To: Christoph Hellwig Cc: xfs@oss.sgi.com Christoph Hellwig wrote: > This macro is unused an all other acros in this family operate on native > types, so we most likely won't grow a user either. Looks good to me... FWIW, here are the currently-unused macros in xfs cvs, if I'm massaging it right: _ACL_ACCESS_EXISTS _ACL_GET_ACCESS ATTR_DONTFOLLOW ATTR_TRUST BMBT_USE_64 CE_CONT current_clear_flags_nested FSYNC_INVAL FSYNC_NOWAIT HAVE_DM_EVENTTYPE_T HAVE_DM_RIGHT_T HAVE_SPLICE MODEMASK NDPP nested_spinlock nested_spinunlock SGI_ACL_DEFAULT_SIZE SV_KEYED SV_LIFO SV_PRIO sv_timedwait sv_timedwait_sig sv_wait_sig TRACE0 TRACE1 TRACE3 VN_ISBLK VN_ISCHR VN_ISLNK VREAD VSUID VSVTX VWRITE XB_GET_OWNER XFS_AT_ALL XFS_AT_SIZE_NOPERM XFS_AT_TIMES xfs_buf_ctob XFS_BUF_ISORDERED XFS_BUF_ISWRITE XFS_BUF_OFFSET XFS_BUF_SET_OFFSET XFS_BUF_SET_SIZE XFS_BUF_UNBUSY XFS_BUF_VSEMA XFS_DA_MAXHASH XFS_DFORK_ASIZE_HOST XFS_DFORK_DSIZE_HOST XFS_ERRLEVEL_OFF XFS_ERRTAG_DIOWRITE_IOERR XFS_ERRTAG_MAX XFS_ERRTAG_NOERROR XFS_ERRTAG_STRATCMPL_IOERR XFS_ERRTAG_STRATREAD_IOERR XFS_EXTENT_TOKEN_WR XFS_IO_DCXVN XFS_IOMAP_WRITE_UNWRITTEN XFS_IS_PQUOTA_RUNNING XFS_LID_PINNED XFS_MAX_LOG_BLOCKS XFS_MAX_LOG_BYTES xfs_probe_dmapi xfs_probe_ioops xfs_probe_quota XFS_QMOPT_DOLOG XFS_RANDOM_DIOWRITE_IOERR XFS_RANDOM_STRATCMPL_IOERR XFS_RANDOM_STRATREAD_IOERR XFS_SBF_NOFLAGS XFS_SB_VERSION2_REALFBITS XFS_SB_VERSION2_RESERVED1BIT XFS_SB_VERSION2_RESERVED4BIT XFS_SB_VERSION_ADDDALIGN XFS_SB_VERSION_ADDEXTFLGBIT XFS_SB_VERSION_ADDSHARED XFS_SB_VERSION_SUBEXTFLGBIT XFS_SB_VERSION_SUBSHARED XFS_SIZE_TOKEN_WR XFS_SX_VERSION xlog_exit XLOG_FMT_IRIX_BE XLOG_MIN_RECORD_BSHIFT XLOG_RHASH_BITS XLOG_SET XLOG_STATE_NOTUSED -Eric