* Review: fix mount flags as printed by xfsidbg
@ 2007-09-24 9:20 Donald Douwsma
2007-09-24 16:14 ` Chris Wedgwood
2007-09-24 18:02 ` Christoph Hellwig
0 siblings, 2 replies; 4+ messages in thread
From: Donald Douwsma @ 2007-09-24 9:20 UTC (permalink / raw)
To: xfs-oss
The xfs mount flags have recently undergone some changes.
Update the xfsidbg xmount command to print them correctly.
Don
--- 2.6.x-xfs.orig/fs/xfs/xfsidbg.c
+++ 2.6.x-xfs/fs/xfs/xfsidbg.c
@@ -6403,25 +6403,25 @@ xfsidbg_xmount(xfs_mount_t *mp)
static char *xmount_flags[] = {
"WSYNC", /* 0x0001 */
"INO64", /* 0x0002 */
- "UNUSED_4", /* 0x0004 */
- "UNUSED_8", /* 0x0008 */
+ "DMAPI", /* 0x0004 */
+ "WAS_CLEAN", /* 0x0008 */
"FSSHUTDOWN", /* 0x0010 */
"NOATIME", /* 0x0020 */
"RETERR", /* 0x0040 */
"NOALIGN", /* 0x0080 */
"ATTR2", /* 0x0100 */
- "UNUSED_200", /* 0x0200 */
+ "GRPID", /* 0x0200 */
"NORECOVERY", /* 0x0400 */
"SHARED", /* 0x0800 */
"DFLT_IOSIZE", /* 0x1000 */
"OSYNCISOSYNC", /* 0x2000 */
"32BITINODES", /* 0x4000 */
- "32BITINOOPT", /* 0x8000 */
+ "SMALL_INUMS", /* 0x8000 */
"NOUUID", /* 0x10000 */
"BARRIER", /* 0x20000 */
"IDELETE", /* 0x40000 */
"SWALLOC", /* 0x80000 */
- "UNUSED_100000", /* 0x100000 */
+ "RDONLY", /* 0x100000 */
"DIRSYNC", /* 0x200000 */
"COMPAT_IOSIZE",/* 0x400000 */
NULL
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Review: fix mount flags as printed by xfsidbg
2007-09-24 9:20 Review: fix mount flags as printed by xfsidbg Donald Douwsma
@ 2007-09-24 16:14 ` Chris Wedgwood
2007-09-24 18:03 ` Christoph Hellwig
2007-09-24 18:02 ` Christoph Hellwig
1 sibling, 1 reply; 4+ messages in thread
From: Chris Wedgwood @ 2007-09-24 16:14 UTC (permalink / raw)
To: Donald Douwsma; +Cc: xfs-oss
On Mon, Sep 24, 2007 at 07:20:25PM +1000, Donald Douwsma wrote:
> - "32BITINOOPT", /* 0x8000 */
> + "SMALL_INUMS", /* 0x8000 */
why rename that?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Review: fix mount flags as printed by xfsidbg
2007-09-24 9:20 Review: fix mount flags as printed by xfsidbg Donald Douwsma
2007-09-24 16:14 ` Chris Wedgwood
@ 2007-09-24 18:02 ` Christoph Hellwig
1 sibling, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2007-09-24 18:02 UTC (permalink / raw)
To: Donald Douwsma; +Cc: xfs-oss
On Mon, Sep 24, 2007 at 07:20:25PM +1000, Donald Douwsma wrote:
> The xfs mount flags have recently undergone some changes.
> Update the xfsidbg xmount command to print them correctly.
>
> Don
Looks good.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Review: fix mount flags as printed by xfsidbg
2007-09-24 16:14 ` Chris Wedgwood
@ 2007-09-24 18:03 ` Christoph Hellwig
0 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2007-09-24 18:03 UTC (permalink / raw)
To: Chris Wedgwood; +Cc: Donald Douwsma, xfs-oss
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=unknown-8bit, Size: 393 bytes --]
On Mon, Sep 24, 2007 at 09:14:33AM -0700, Chris Wedgwood wrote:
> On Mon, Sep 24, 2007 at 07:20:25PM +1000, Donald Douwsma wrote:
>
> > - "32BITINOOPT", /* 0x8000 */
> > + "SMALL_INUMS", /* 0x8000 */
>
> why rename that?
It's just renamed to what's æctually in the mount flags. We didn't
actually have a 32BITINOOPT flag before so it's a bit of a mistery
how the original one got there.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-09-24 18:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-24 9:20 Review: fix mount flags as printed by xfsidbg Donald Douwsma
2007-09-24 16:14 ` Chris Wedgwood
2007-09-24 18:03 ` Christoph Hellwig
2007-09-24 18:02 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox