Re: [PATCH] lose xfs_hex_dump in favor of print_hex_dump

Eric Sandeen
2007-09-25T01:31:51Z

Chris Wedgwood wrote:

> On Mon, Sep 24, 2007 at 07:11:44PM -0500, Eric Sandeen wrote:
>
>> +extern void xfs_hex_dump(void *p, int length);
>> +
>
>> +void
>> +xfs_hex_dump(void *p, int length)
>> +{
>> + print_hex_dump(KERN_ALERT, "", DUMP_PREFIX_OFFSET, 16, 1, p, length, 1);
>> +}
>
> Is this symbol exported/needed? If not then why not make it a #define
> or an inline in the header where you have the prototype?

Yeah, I suppose that might be better.... I just followed the lead of
xfs_cmn_err etc.

The only reason I left a wrapper was for cattelan's BSD exploits
(er, adventures) ;-) I could imagine it getting called from other places,
but for now it only has one caller, xfs_corruption_error (so really, even
the length argument is never anything other than 16...)

-Eric