Re: [PATCH] lose xfs_hex_dump in favor of print_hex_dump

Chris Wedgwood
2007-09-25T00:32:36Z

On Mon, Sep 24, 2007 at 07:11:44PM -0500, Eric Sandeen wrote:

> +extern void xfs_hex_dump(void *p, int length);
> +

> +void
> +xfs_hex_dump(void *p, int length)
> +{
> + print_hex_dump(KERN_ALERT, "", DUMP_PREFIX_OFFSET, 16, 1, p, length, 1);
> +}

Is this symbol exported/needed? If not then why not make it a #define
or an inline in the header where you have the prototype?