From: Donald Douwsma <donaldd@sgi.com>
To: Christoph Hellwig <hch@lst.de>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfsidbg: kill vnode leftovers
Date: Tue, 25 Sep 2007 15:53:11 +1000 [thread overview]
Message-ID: <46F8A247.4070607@sgi.com> (raw)
In-Reply-To: <20070924180732.GA17635@lst.de>
Christoph Hellwig wrote:
> While we're at fixing up xfsidbg I have this little gem:
>
> Kill the kdbm_vn, kdbm_vnode and xi2vnode xfsidbg commands.
>
> The last one just printed a Linux inode (despite it's description)
> and that is much better done by the inode command in
> kdb/modules/kdbm_pg.c. The latter two both print the vnode (nothing
> left here) and the inode and again that is better done using the
> inode command. Interestingly those latter two did exactly the
> same despite their quite different descriptions which weren't
> correct for either command.
>
Thanks Christoph, its good to remove the cruft.
78 commands in there at the moment. Any we can get rid of make it easier to use.
Don
prev parent reply other threads:[~2007-09-25 5:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-24 18:07 [PATCH] xfsidbg: kill vnode leftovers Christoph Hellwig
2007-09-25 5:53 ` Donald Douwsma [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46F8A247.4070607@sgi.com \
--to=donaldd@sgi.com \
--cc=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox