From: Donald Douwsma <donaldd@sgi.com>
To: Christoph Hellwig <hch@lst.de>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/2] kill xfs_freeze
Date: Wed, 26 Sep 2007 10:10:54 +1000 [thread overview]
Message-ID: <46F9A38E.6000200@sgi.com> (raw)
In-Reply-To: <20070925194528.GA1818@lst.de>
Christoph Hellwig wrote:
> No need to have a wrapper just two call two more functions.
...
>
> Index: linux-2.6-xfs/fs/xfs/xfs_vfsops.c
> ===================================================================
> --- linux-2.6-xfs.orig/fs/xfs/xfs_vfsops.c 2007-09-23 13:54:35.000000000 +0200
> +++ linux-2.6-xfs/fs/xfs/xfs_vfsops.c 2007-09-23 13:56:12.000000000 +0200
> @@ -692,7 +692,7 @@ xfs_quiesce_fs(
> * care of the metadata. New transactions are already blocked, so we need to
> * wait for any remaining transactions to drain out before proceding.
> */
> -STATIC void
> +void
> xfs_attr_quiesce(
> xfs_mount_t *mp)
> {
> Index: linux-2.6-xfs/fs/xfs/xfs_vfsops.h
> ===================================================================
> --- linux-2.6-xfs.orig/fs/xfs/xfs_vfsops.h 2007-09-23 13:56:16.000000000 +0200
> +++ linux-2.6-xfs/fs/xfs/xfs_vfsops.h 2007-09-23 13:56:34.000000000 +0200
This has removed all use of xfs_freeze, but I cant see a diff
hunk that removes the xfs_freeze implementation from xfs_vfsops.c
Don
next prev parent reply other threads:[~2007-09-26 0:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-25 19:45 [PATCH 1/2] kill xfs_freeze Christoph Hellwig
2007-09-26 0:10 ` Donald Douwsma [this message]
2007-09-26 8:23 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46F9A38E.6000200@sgi.com \
--to=donaldd@sgi.com \
--cc=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox