Re: [PATCH V2] refactor xfs_mountfs for clarity & stack savings

[Donald Douwsma <donaldd@sgi.com>]

Eric Sandeen wrote:
> Refactoring xfs_mountfs() to call sub-functions for logical
> chunks can help save a bit of stack, and can make it easier to
> read this long function.

Finally got around to reviewing this one, sorry for the delay.

I think we've lost something in the refactoring.

> Index: linux-2.6-xfs/fs/xfs/xfs_mount.c
...
> -	/*
> -	 * XFS uses the uuid from the superblock as the unique
> -	 * identifier for fsid.  We can not use the uuid from the volume
> -	 * since a single partition filesystem is identical to a single
> -	 * partition volume/filesystem.
> -	 */
> -	if ((mfsi_flags & XFS_MFSI_SECOND) == 0 &&
> -	    (mp->m_flags & XFS_MOUNT_NOUUID) == 0) {
> -		if (xfs_uuid_mount(mp)) {
> -			error = XFS_ERROR(EINVAL);
> -			goto error1;
> -		}
> -		uuid_mounted=1;

The patch removes uuid_mounted=1, but doesn't put it back in anywhere.
I think we need that bit for error handling :)

Don