From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: with ECARTIS (v1.0.0; list xfs); Mon, 01 Oct 2007 05:39:53 -0700 (PDT) Received: from sandeen.net (sandeen.net [209.173.210.139]) by oss.sgi.com (8.12.11.20060308/8.12.10/SuSE Linux 0.7) with ESMTP id l91Cdmfu016554 for ; Mon, 1 Oct 2007 05:39:50 -0700 Message-ID: <4700EA92.1030004@sandeen.net> Date: Mon, 01 Oct 2007 07:39:46 -0500 From: Eric Sandeen MIME-Version: 1.0 Subject: Re: [PATCH V2] refactor xfs_mountfs for clarity & stack savings References: <46D37A82.2080608@sandeen.net> <20070828195221.GA7237@infradead.org> <46D48BDE.5000903@sandeen.net> <4700A68A.8070609@sgi.com> In-Reply-To: <4700A68A.8070609@sgi.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com List-Id: xfs To: Donald Douwsma Cc: Christoph Hellwig , xfs-oss Donald Douwsma wrote: > Eric Sandeen wrote: >> Refactoring xfs_mountfs() to call sub-functions for logical >> chunks can help save a bit of stack, and can make it easier to >> read this long function. > > Finally got around to reviewing this one, sorry for the delay. > > I think we've lost something in the refactoring. > >> Index: linux-2.6-xfs/fs/xfs/xfs_mount.c > ... >> - /* >> - * XFS uses the uuid from the superblock as the unique >> - * identifier for fsid. We can not use the uuid from the volume >> - * since a single partition filesystem is identical to a single >> - * partition volume/filesystem. >> - */ >> - if ((mfsi_flags & XFS_MFSI_SECOND) == 0 && >> - (mp->m_flags & XFS_MOUNT_NOUUID) == 0) { >> - if (xfs_uuid_mount(mp)) { >> - error = XFS_ERROR(EINVAL); >> - goto error1; >> - } >> - uuid_mounted=1; > > The patch removes uuid_mounted=1, but doesn't put it back in anywhere. > I think we need that bit for error handling :) Hm, no idea how I lost that... maybe in bouncing from cvs to kernel.org version. Sorry, will look this evening & fix it up. -Eric