From: Timothy Shimmin <tes@sgi.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, xfs@oss.sgi.com, akpm@linux-foundation.org
Subject: Re: [GIT PULL] XFS update for 2.6.23 - revert a commit
Date: Tue, 02 Oct 2007 10:13:48 +1000 [thread overview]
Message-ID: <47018D3C.9070409@sgi.com> (raw)
In-Reply-To: <alpine.LFD.0.999.0710010753500.3579@woody.linux-foundation.org>
Linus Torvalds wrote:
>
> On Mon, 1 Oct 2007, Tim Shimmin wrote:
>> Lachlan's description:
>> This fix is for a problem that has been in XFS since day one.
>> [XFS] Avoid replaying inode buffer initialisation log items if on-disk version is newer.
> ...
>
> Why wasn't this in the commit logs? Now it just says it was reverted, with
> no actual reasoning *why*. And it apparently wasn't so obvious that no
> such reasoning is needed.
>
> Gah. I ended up amending the commit and updating it with the comment.
>
> Linus
Yeah, sorry about that.
It occurred to me later on.
I initially converted the sgi-mod (undo mod) to a git commit and
then discovered git-revert and thought, hey I'll use that
instead but then forgot to add all the text into it.
D'oh. Thanks for the fixup.
--Tim
prev parent reply other threads:[~2007-10-02 0:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-01 7:23 [GIT PULL] XFS update for 2.6.23 - revert a commit Tim Shimmin
2007-10-01 12:55 ` Eric Sandeen
2007-10-01 13:05 ` Eric Sandeen
2007-10-01 13:12 ` Eric Sandeen
2007-10-02 1:41 ` Timothy Shimmin
2007-10-02 7:03 ` Lachlan McIlroy
2007-10-02 8:43 ` Justin Piszcz
2007-10-03 1:49 ` Timothy Shimmin
2007-10-03 8:11 ` Justin Piszcz
2007-10-04 0:26 ` David Chinner
2007-10-04 10:59 ` Justin Piszcz
2007-10-02 9:36 ` David Chinner
2007-10-01 15:02 ` Linus Torvalds
2007-10-02 0:13 ` Timothy Shimmin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47018D3C.9070409@sgi.com \
--to=tes@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox