Re: [PATCH] XFS bitops to Linux again

[Eric Sandeen <sandeen@sandeen.net>]

nscott@aconex.com wrote:

> Great.  You're light years ahead of the rest of the cleanup brigade. :)

Hey, I resemble that remark!  :)

(FWIW, I too first ran through xfsqa with both calculations in place,
and caused it to complain loudly if there was a mismatch.  Not 100%
coverage, but I'm not trying to do this half-assed either...)

>> I did also some simple tests using the QA suite -- i believe a few logs
>> were recovered -- but not the full tests.
> 
> From a quick look, tests 085, 086 and 087 are the ones I was thinking of
> yesterday.
> 
>>> To be honest, this sounds like just code churn and risk
>>> introduction.
>> Ok I got the message. I retract the patch. Sorry for bothering you
>> with lowly cleanups.
> 
> Hey, I like cleanup as much as the next guy (as long as the next guy isn't
> Eric,
> he just lives to clean ;)

If I do any real work I might lose my job ;-) </joke>

> - also always ignores userspace despite knowing
> better)

Nah, I just forget.

-Eric