From: Donald Douwsma <donaldd@sgi.com>
To: xfs-oss <xfs@oss.sgi.com>
Subject: Review: Fix dbflush panic in xfs_qm_sync
Date: Tue, 16 Oct 2007 09:29:23 +1000 [thread overview]
Message-ID: <4713F7D3.2090201@sgi.com> (raw)
The recent behaviour layer removal dropped the check for quotas that have been
requested at mount time but have subsequently been turned off. This results
in a panic when accessing m_quotainfo which has been freed.
This patch adds the check originally made by xfs_qm_syncall() to xfs_qm_sync()
Signed-off-by: Donald Douwsma <donaldd@sgi.com>
--- 2.6.x-xfs.orig/fs/xfs/quota/xfs_qm.c
+++ 2.6.x-xfs/fs/xfs/quota/xfs_qm.c
@@ -1007,6 +1007,9 @@ xfs_qm_sync(
boolean_t nowait;
int error;
+ if (! XFS_IS_QUOTA_ON(mp))
+ return 0;
+
restarts = 0;
/*
* We won't block unless we are asked to.
next reply other threads:[~2007-10-15 23:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-15 23:29 Donald Douwsma [this message]
2007-10-16 5:18 ` Review: Fix dbflush panic in xfs_qm_sync Lachlan McIlroy
2007-10-16 6:07 ` David Chinner
2007-10-17 1:54 ` Donald Douwsma
2007-10-18 16:16 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4713F7D3.2090201@sgi.com \
--to=donaldd@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox