public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Vlad Apostolov <vapo@sgi.com>
To: xfs-dev <xfs-dev@sgi.com>
Cc: xfs mailing list <xfs@oss.sgi.com>
Subject: Re: Review: Make xfs_bulkstat() to report unlinked but referenced inodes
Date: Fri, 19 Oct 2007 10:51:29 +1000	[thread overview]
Message-ID: <4717FF91.5010902@sgi.com> (raw)
In-Reply-To: <4715A22D.1070409@sgi.com>

ping!

I ran XFS QA with this patch and didn't see any regressions and
I (and Judith in US) have verified the expected behavior - xfs_bulkstat()
now reports referenced inodes with link count of zero.

Regards,
Vlad

Vlad Apostolov wrote:
> We need xfs_bulkstat() to report inode stat for inodes with
> link count zero but reference count non zero.
>
> The fix here:
>
> http://oss.sgi.com/archives/xfs/2007-09/msg00266.html
>
> changed this behavior and made xfs_bulkstat() to filter all
> unlinked inodes including those that are not destroyed yet but
> held by reference.
>
> The attached patch returns back to the original behavior by
> marking the on-disk inode buffer "dirty" when di_mode is cleared
> (at that time both inode link and reference counter are zero).
>
> Regards,
> Vlad

  reply	other threads:[~2007-10-19  0:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-17  5:48 Review: Make xfs_bulkstat() to report unlinked but referenced inodes Vlad Apostolov
2007-10-19  0:51 ` Vlad Apostolov [this message]
2007-10-19  0:57   ` David Chinner
  -- strict thread matches above, loose matches on Subject: below --
2007-10-17  2:16 Vlad Apostolov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4717FF91.5010902@sgi.com \
    --to=vapo@sgi.com \
    --cc=xfs-dev@sgi.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox