From: Eric Sandeen <sandeen@sandeen.net>
To: xfs-masters@oss.sgi.com
Cc: xfs@oss.sgi.com, kernel-janitors@vger.kernel.org
Subject: Re: [xfs-masters] [PATCH] fs/xfs: remove duplicated defines
Date: Sun, 11 Nov 2007 17:57:35 -0600 [thread overview]
Message-ID: <473796EF.6050104@sandeen.net> (raw)
In-Reply-To: <20071111134351.106efb98@lucky.kitzblitz>
Nicolas Kaiser wrote:
> Remove duplicated defines.
>
> Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
> ---
Heh, each defined twice, but used 0 times in the kernel. Could probably
just remove them altogether (though I guess btoc is used in
xfstests/ltp/doio.c in userspace/xfstests, but that's the *only* place)
-Eric
> fs/xfs/linux-2.6/xfs_linux.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> --- a/fs/xfs/linux-2.6/xfs_linux.h 2007-11-07 11:26:20.000000000 +0100
> +++ b/fs/xfs/linux-2.6/xfs_linux.h 2007-11-11 13:07:11.000000000 +0100
> @@ -167,12 +167,8 @@
>
> /* clicks to bytes */
> #define ctob(x) ((__psunsigned_t)(x)<<BPCSHIFT)
> -#define btoct(x) ((__psunsigned_t)(x)>>BPCSHIFT)
> #define ctob64(x) ((__uint64_t)(x)<<BPCSHIFT)
>
> -/* bytes to clicks */
> -#define btoc(x) (((__psunsigned_t)(x)+(NBPC-1))>>BPCSHIFT)
> -
> #define ENOATTR ENODATA /* Attribute not found */
> #define EWRONGFS EINVAL /* Mount with wrong filesystem type */
> #define EFSCORRUPTED EUCLEAN /* Filesystem is corrupted */
>
>
next parent reply other threads:[~2007-11-11 23:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20071111134351.106efb98@lucky.kitzblitz>
2007-11-11 23:57 ` Eric Sandeen [this message]
2007-11-12 0:09 ` [xfs-masters] [PATCH] fs/xfs: remove duplicated defines Timothy Shimmin
[not found] ` <47379E42.2030006@sgi.com>
[not found] ` <47379F5A.20107@sgi.com>
[not found] ` <20071112020445.GY995458@sgi.com>
[not found] ` <473937AC.2080901@sgi.com>
[not found] ` <20071113213013.GZ995458@sgi.com>
[not found] ` <473A619C.8040206@sgi.com>
[not found] ` <20071114054100.GJ995458@sgi.com>
[not found] ` <473B98AC.2000600@sgi.com>
[not found] ` <20071115062728.GH66820511@sgi.com>
[not found] ` <473D2BFB.6040702@sgi.com>
2007-11-16 6:15 ` [xfs-masters] [PATCH] remove BPCSHIFT and NB?P? macros - was " Lachlan McIlroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=473796EF.6050104@sandeen.net \
--to=sandeen@sandeen.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=xfs-masters@oss.sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox